Re: [PATCH v2 1/6] dt-bindings: spi: sun6i: add DT bindings for Allwinner R329 SPI
From: Krzysztof Kozlowski <hidden>
Date: 2023-05-07 07:42:15
Also in:
linux-devicetree, linux-riscv, linux-spi, linux-sunxi, lkml
On 06/05/2023 14:59, Maxim Kiselev wrote:
quoted
Should this not be set up as a fallback compatible, per Samuel's suggestion here:Ok, I'll do it in the next version.quoted
I wonder what is the difference of DBI compatible. You refer to "helper functions", which sounds like driver... do you mean some parts of SPI controller?According to the D1 datasheet the SPI_DBI controller uses the same registers layout as the regular SPI0 controller. But also it has an additional DBI mode functionality. Support for this mode is not yet implemented. So there is no difference between 'sun50i-r329-spi' and 'sun50i-r329-spi-dbi' controllers types in the SPI driver. Maybe we should drop 'sun50i-r329-spi-dbi' compatible struct from here https://lore.kernel.org/lkml/20230506073018.1411583-5-bigunclemax@gmail.com/ (local) for a while the DBI mode functionality will not be implemented?
You need both compatibles, but keep DBI compatible with regular one. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel