Re: [PATCH v3 07/18] arm64: defconfig: Enable Qualcomm minidump driver

On 04/05/2023 13:45, Mukesh Ojha wrote:

On 5/4/2023 4:53 PM, Krzysztof Kozlowski wrote:

quoted

On 03/05/2023 19:02, Mukesh Ojha wrote:

quoted

Previous patches add the Qualcomm minidump driver support, so
lets enable minidump config so that it can be used by kernel
clients.

Signed-off-by: Mukesh Ojha <redacted>

This patchset is split too much. Defconfig change is one change. Not two
or three.

quoted

---
  arch/arm64/configs/defconfig | 1 +
  1 file changed, 1 insertion(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index a24609e..831c942 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig

@@ -1250,6 +1250,7 @@ CONFIG_QCOM_STATS=m
  CONFIG_QCOM_WCNSS_CTRL=m
  CONFIG_QCOM_APR=m
  CONFIG_QCOM_ICC_BWMON=m
+CONFIG_QCOM_MINIDUMP=y

This must be a module.

Why do you think this should be a module ?

Is it because, it is lying here among others '=m' ?

Because we want and insist on everything being a module. That's the
generic rule. There are exceptions, so if this justifies being an
exception, please bring appropriate arguments.

Or you have some other reasoning ? like it is for qcom specific
soc and can not be used outside ? but that is not true for
all configs mentioned here.

The reason behind making it as '=y' was, to collect information from 
core kernel data structure as well as the information like percpu data, 
run queue, irq stat kind of information on kernel crash on a target 
running some perf configuration(android phone).

I don't understand why =m stops you from all that. What's more, I don't
understand why do you refer to the Android here. This is a development
and debugging Linux defconfig, not Android reference config for vendors...

Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel