Re: [PATCH 11/15] PCI: mt7621: Convert to platform remove callback returning void
From: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Date: 2023-03-22 06:42:01
Also in:
linux-mediatek, linux-pci
On Tue, Mar 21, 2023 at 8:32 PM Uwe Kleine-König [off-list ref] wrote:
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <redacted> --- drivers/pci/controller/pcie-mt7621.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
Reviewed-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Best regards,
Sergio Paracuellos
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel