On Mon, Mar 27, 2023 at 01:46:33PM +0200, Pavel Machek wrote:

Hi!

quoted

The MediaTek MT6370 is a highly-integrated smart power management IC,
which includes a single cell Li-Ion/Li-Polymer switching battery
charger, a USB Type-C & Power Delivery (PD) controller, dual
Flash LED current sources, a RGB LED driver, a backlight WLED driver,
a display bias driver and a general LDO for portable devices.

Add support for the MediaTek MT6370 Current Sink Type LED Indicator
driver. It can control four channels current-sink RGB LEDs with 3 modes:
constant current, PWM, and breath mode.

Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Co-developed-by: Alice Chen <redacted>
Signed-off-by: Alice Chen <redacted>
Signed-off-by: ChiYuan Huang <redacted>
Signed-off-by: ChiaEn Wu <redacted>

quoted

+++ b/drivers/leds/rgb/Makefile

@@ -2,3 +2,4 @@
 
 obj-$(CONFIG_LEDS_PWM_MULTICOLOR)	+= leds-pwm-multicolor.o
 obj-$(CONFIG_LEDS_QCOM_LPG)		+= leds-qcom-lpg.o
+obj-$(CONFIG_LEDS_MT6370_RGB)		+= leds-mt6370-rgb.o

I'd preffer leds-mt6370 name. We already have "rgb" in directory
name...

Yap, sure,

But for mt6370 leds, except rgb indicators, there are also flashes for camera.
To keep the postfix in filename can more precisely tell what the file for.

Otherwise looks good. Thanks for doing this.

BR,
								Pavel
-- 
People of Russia, stop Putin before his war on Ukraine escalates.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel