Hi,

-----Original Message-----
From: Herbert Xu <herbert@gondor.apana.org.au>
Sent: Friday, March 10, 2023 4:02 PM
To: Harsha, Harsha <harsha.harsha@amd.com>
Cc: davem@davemloft.net; linux-crypto@vger.kernel.org; linux-
kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
michals@xilinx.com; saratcha@xilinx.com; git (AMD-Xilinx) [off-list ref];
Shah, Dhaval (CPG-PSAV) [off-list ref]
Subject: Re: [PATCH 3/4] crypto: xilinx: Add ZynqMP RSA driver

On Sat, Feb 18, 2023 at 11:08:08AM +0530, Harsha Harsha wrote:

quoted

+			.cra_flags = CRYPTO_ALG_TYPE_AKCIPHER |
+				     CRYPTO_ALG_KERN_DRIVER_ONLY |
+				     CRYPTO_ALG_ALLOCATES_MEMORY |
+				     CRYPTO_ALG_NEED_FALLBACK,

The driver appears to be async so you should set the flag
CRYPTO_ALG_ASYNC.

Thanks for the review.
For the RSA driver, below is the flow of operation:
RSA linux driver -> ATF -> Firmware -> RSA hardware engine.

To perform the operation, the request goes to the RSA HW engine. Once the operation is done, the response is sent back
via firmware and ATF to the linux driver. Meanwhile the API in the linux driver waits until the operation is complete.
This is why the driver is synchronous and therefore the CRYPTO_ALG_ASYNC flag is not set.

Regards,
Harsha

Thanks,
--
Email: Herbert Xu [off-list ref] Home Page:
http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel