Hi Linus and Andy,

On Tue, Mar 07, 2023 at 01:49:00PM +0100, Linus Walleij wrote:

On Tue, Mar 7, 2023 at 10:56 AM Andy Shevchenko
[off-list ref] wrote:

quoted

On Tue, Mar 7, 2023 at 11:22 AM Linus Walleij [off-list ref] wrote:

quoted

On Tue, Mar 7, 2023 at 12:28 AM [off-list ref] wrote:

...

quoted

quoted

Can you unpull this?

quoted

If need be.

Are there serious issues with the patch set such that they cannot be fixed
by add-on patches?

There are a few absent error checks, some error code shadowing, etc.
I can't tell if these all are serious, but the amount of them is like a dozen.

I reviewed the patch, so you can look into that yourself and decide.

I looked at it and some of the comments are pretty serious and need
addressing ASAP.

Thanks for reviewing the patch.

Please kindly leave review comments if it doesn't take too much time for you.
I just want to ensure that I won't miss anything.

However it only affects this hardware so it's not like it's breaking the
world. I generally prefer in-tree development over too many big patch
iterations, it gets more focused.

I think if Chester can follow up with a patch or several addressing the
comments in the next week or two that's fine.

I will do my best to solve it.

Thanks,
Chester

However if we get closer to -rc6 and nothing has happened I would
not be so happy and then I might just revert the driver patch.

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel