-----Original Message-----
From: Krzysztof Kozlowski <redacted>
Sent: Thursday, February 16, 2023 4:38 PM
To: Shradha Todi <redacted>; lpieralisi@kernel.org;
kw@linux.com; robh@kernel.org; bhelgaas@google.com;
krzysztof.kozlowski+dt@linaro.org; alim.akhtar@samsung.com;
jingoohan1@gmail.com; Sergey.Semin@baikalelectronics.ru;
lukas.bulwahn@gmail.com; hongxing.zhu@nxp.com; tglx@linutronix.de;
m.szyprowski@samsung.com; jh80.chung@samsung.co;
pankaj.dubey@samsung.com
Cc: linux-pci@vger.kernel.org; devicetree@vger.kernel.org; linux-arm-
kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux-
kernel@vger.kernel.org
Subject: Re: [PATCH 09/16] PCI: samsung: Make common appl readl/writel
functions

On 14/02/2023 13:13, Shradha Todi wrote:

quoted

Common application logic register read and write functions used for
better readability.

Signed-off-by: Shradha Todi <redacted>
---
 drivers/pci/controller/dwc/pci-samsung.c | 54
++++++++++++------------
 1 file changed, 27 insertions(+), 27 deletions(-)

diff --git a/drivers/pci/controller/dwc/pci-samsung.c

b/drivers/pci/controller/dwc/pci-samsung.c
index be0177fcd763..e6e2a8ab4403 100644

--- a/drivers/pci/controller/dwc/pci-samsung.c
+++ b/drivers/pci/controller/dwc/pci-samsung.c

@@ -79,63 +79,63 @@ static void exynos_pcie_deinit_clk_resources(struct

samsung_pcie *sp)

quoted

 	clk_bulk_disable_unprepare(sp->clk_cnt, sp->clks);  }

-static void exynos_pcie_writel(void __iomem *base, u32 val, u32 reg)
+static void samsung_pcie_appl_writel(struct samsung_pcie *sp, u32
+val, u32 reg)

No for renaming - same reason as for previous patch.

I have tried to justify our rational behind this in previous patch, I hope that makes sense.

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel