Re: [RFC PATCH 07/16] dt-bindings: pinctrl: ralink: add new compatible strings
From: Arınç ÜNAL <hidden>
Date: 2023-02-28 16:47:23
Also in:
linux-devicetree, linux-gpio, linux-mediatek, linux-mips, lkml
On 27/02/2023 20:33, Rob Herring wrote:
On Wed, Feb 22, 2023 at 09:39:23PM +0300, arinc9.unal@gmail.com wrote:quoted
From: Arınç ÜNAL <redacted> Add the ralink,rt2880-pinmux compatible string. It had been removed from the driver which broke the ABI. Add the mediatek compatible strings. Change the compatible string on the examples with the mediatek compatible strings. Signed-off-by: Arınç ÜNAL <redacted> --- .../devicetree/bindings/pinctrl/ralink,mt7620-pinctrl.yaml | 7 +++++-- .../devicetree/bindings/pinctrl/ralink,mt7621-pinctrl.yaml | 7 +++++-- .../devicetree/bindings/pinctrl/ralink,rt2880-pinctrl.yaml | 7 +++++-- .../devicetree/bindings/pinctrl/ralink,rt305x-pinctrl.yaml | 7 +++++-- .../devicetree/bindings/pinctrl/ralink,rt3883-pinctrl.yaml | 7 +++++-- 5 files changed, 25 insertions(+), 10 deletions(-)diff --git a/Documentation/devicetree/bindings/pinctrl/ralink,mt7620-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/ralink,mt7620-pinctrl.yaml index 1e63ea34146a..531b5f616c3d 100644 --- a/Documentation/devicetree/bindings/pinctrl/ralink,mt7620-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/ralink,mt7620-pinctrl.yaml@@ -17,7 +17,10 @@ description: properties: compatible: - const: ralink,mt7620-pinctrl + enum: + - mediatek,mt7620-pinctrl + - ralink,mt7620-pinctrlWe don't update compatible strings based on acquistions nor marketing whims. If you want to use 'mediatek' for new things, then fine.
Understood. Only the SoCs with rtXXXX were rebranded, the mtXXXX SoCs share the same architecture from Ralink, so they were incorrectly called Ralink SoCs. I can remove the new strings from Ralink SoCs and add them only for MediaTek SoCs. Or you could make an exception for this one, regarding the situation. Whatever you think is best. Arınç _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel