Re: [PATCH v2 6/6] clk: samsung: exynos5433: Extract PM support to common ARM64 layer
From: Marek Szyprowski <m.szyprowski@samsung.com>
Date: 2023-02-21 07:23:09
Also in:
linux-clk, linux-samsung-soc, lkml
On 19.02.2023 18:36, Sam Protsenko wrote:
On Wed, 8 Feb 2023 at 17:43, Sam Protsenko [off-list ref] wrote:quoted
Exynos5433 clock driver implements PM support internally, which might be also useful for other Exynos clock drivers. Extract all PM related code from clk-exynos5433 to common ARM64 functions. Tested-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> --- Changes in v2: - Rebased on top of latest soc/for-next tree - Included linux/slab.h for kfree (found by kernel test robot) drivers/clk/samsung/clk-exynos-arm64.c | 171 ++++++++++++++++++++++++- drivers/clk/samsung/clk-exynos-arm64.h | 3 + drivers/clk/samsung/clk-exynos5433.c | 157 +---------------------- 3 files changed, 175 insertions(+), 156 deletions(-)diff --git a/drivers/clk/samsung/clk-exynos-arm64.c b/drivers/clk/samsung/clk-exynos-arm64.c index 2aa3f0a5644e..7ad7fd353dda 100644 --- a/drivers/clk/samsung/clk-exynos-arm64.c +++ b/drivers/clk/samsung/clk-exynos-arm64.c@@ -10,6 +10,9 @@ */Hi Marek, It just occurred to me that as I'm pulling your code from clk-exynos5433.c here, I should've probably added you to this file's author list in the header comment. Does that sound right to you? If so, I can re-send v3 with fixes.
Fine for me.
Also, could you please review this series, if possible? I'm working right now on PM_DOMAINS support for Exynos850, so along with this series that would bring the initial PM support for ARM64 Exynos chips.
Well, feel free to add: Acked-by: Marek Szyprowski <m.szyprowski@samsung.com> to v3 (the whole patchset). The only remark I have is not strictly related to this patchset, but the code that is already in drivers/clk/samsung/clk-exynos-arm64.c. Playing with GATE_ENABLE_HWACG/GATE_MANUAL is not strictly specific to all Exynos ARM64 SoCs. GATE_OFF_START/GATE_OFF_END and the enable register bits are something specific to recent Exynos SoCs (like 7885/850/auto9) and don't fit well into the generic arm64 clk PM code, but I don't have a good idea how to move it to the respective clk drivers and keep it simple. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel