Thread (8 messages) 8 messages, 2 authors, 2023-02-17

Re: [PATCH v7 1/6] dt-bindings: mediatek: mt8188: Add binding for MM & INFRA IOMMU

From: Krzysztof Kozlowski <hidden>
Date: 2023-02-17 09:23:43
Also in: linux-devicetree, linux-iommu, linux-mediatek, lkml

On 16/02/2023 06:33, Yong Wu wrote:
From: "Chengci.Xu" <redacted>

Add descriptions for mt8188 IOMMU which also use ARM Short-Descriptor
translation table format.

In mt8188, there are two smi-common HW and IOMMU, one is for vdo(video
output), the other is for vpp(video processing pipe). They connects
with different smi-larbs, then some setting(larbid_remap) is different.
Differentiate them with the compatible string.

Something like this:

  IOMMU(VDO)          IOMMU(VPP)
      |                   |
SMI_COMMON_VDO      SMI_COMMON_VPP

---------------     ----------------
  |     |    ...      |     |    ...
larb0 larb2  ...    larb1 larb3  ...

We also have an IOMMU that is for infra master like PCIe.
And infra master don't have the larb and ports.

Signed-off-by: Chengci.Xu <redacted>
Reviewed-by: Yong Wu <yong.wu@mediatek.com>
---
Hi Krzysztof,
I added some comment about larbid index, this is for readable when
adding iova_region_larb_msk in the code.
I'm not sure if it is ok for you, thus don't keep your A-b currently.
Thanks.
---
 .../bindings/iommu/mediatek,iommu.yaml        |  12 +-
 .../memory/mediatek,mt8188-memory-port.h      | 489 ++++++++++++++++++
 2 files changed, 500 insertions(+), 1 deletion(-)

Acked-by: Krzysztof Kozlowski <redacted>

Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help