Re: [PATCH v2 45/47] clk: mediatek: mt8192: Move apmixedsys clock driver to its own file
From: Chen-Yu Tsai <wenst@chromium.org>
Date: 2023-02-17 08:03:05
Also in:
linux-clk, linux-mediatek, lkml
From: Chen-Yu Tsai <wenst@chromium.org>
Date: 2023-02-17 08:03:05
Also in:
linux-clk, linux-mediatek, lkml
On Tue, Feb 14, 2023 at 9:42 PM AngeloGioacchino Del Regno [off-list ref] wrote:
This is the last man standing in clk-mt8192.c that won't allow us to use the module_platform_driver() macro, and for *no* good reason. Move it to clk-mt8192-apmixedsys.c and while at it, also add a .remove() callback for it. Also, since the need for "clk-mt8192-simple" and "clk-mt8192" was just due to them being in the same file and probing different clocks, and since now there's just one platform_driver struct per file, it seemed natural to rename the `-simple` variant to just "clk-mt8192".
All the above combined, I think this patch is doing a bit too much, but splitting it probably doesn't make much sense either :/
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
So a weak Reviewed-by: Chen-Yu Tsai <wenst@chromium.org> in case anyone objects. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel