Re: [PATCH 2/3] dt-bindings: hwlock: sun6i: Add missing names
From: Krzysztof Kozlowski <hidden>
Date: 2023-02-14 12:37:28
Also in:
linux-devicetree, linux-remoteproc, linux-sunxi, lkml
On 14/02/2023 10:45, Wilken Gottwalt wrote:
On Tue, 14 Feb 2023 00:19:29 +0100 Bastian Germann [off-list ref] wrote:quoted
The allwinner,sun6i-a31-hwspinlock.yaml binding needs clock-names and reset-names set to "ahb" as required by the driver.Hmm, this one is a bit odd. If you look into my earlier versions of the patchset, you may notice, that I actually included these bindings and they were refused. I think the argumentation was like "there is only one bus = no need for it". If it gets accepted now, I really like to know why. (It was some trouble back then to get the documentation properly done and accepted.)
The clock names and resent names are not correct. They should have never been added. If you got comments about this and did not update driver, that's not nice. You just shoved incomplete bindings. :( So indeed to avoid precedence - people pushing fake bindings and avoiding review - NAK on this. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel