Thread (5 messages) 5 messages, 4 authors, 2023-02-09

Re: [PATCH] mm/doc: Replace isolate_lru_page with folio_isolate_lru

From: Matthew Wilcox <willy@infradead.org>
Date: 2023-02-09 13:58:29
Also in: linux-doc, linux-mediatek, linux-mm, lkml

On Thu, Feb 09, 2023 at 03:10:07PM +0200, Mike Rapoport wrote:
On Thu, Feb 02, 2023 at 11:02:11AM -0700, Jonathan Corbet wrote:
quoted
Kuan-Ying Lee [off-list ref] writes:
quoted
Since we introduce folio, replace isolate_lru_page() with
folio_isolate_lru().

Signed-off-by: Kuan-Ying Lee <redacted>
---
 Documentation/mm/page_migration.rst | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
This seems like a good patch to copy to linux-mm - done now.

The patch perhaps is a closer match to what's in linux-next, but it
seems that, if we're going to update this document, we should reflect
the use folios throughout?
Most of the current users of migrate_pages() still use isolate_lru_page()
so I think that updating page_migration.rst to folios is premature.
But when we do the update it also should include the translations.
It's a slim majority -- 9 of isolate_lru_pages() and 7 of
folio_isolate_lru().  I don't think that changing the documentation is
premature; we should document the functions we want people to use.
I'd be surprised if isolate_lru_pages() still existed in six months.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help