Re: [PATCH 6/6] clk: samsung: exynos5433: Extract PM support to common ARM64 layer
From: Sam Protsenko <semen.protsenko@linaro.org>
Date: 2023-02-08 06:08:15
Also in:
linux-clk, linux-samsung-soc, lkml
On Fri, 3 Feb 2023 at 03:18, Krzysztof Kozlowski [off-list ref] wrote:
On 03/02/2023 07:09, Sam Protsenko wrote:quoted
Exynos5433 clock driver implements PM support internally, which might be also useful for other Exynos clock drivers. Extract all PM related code from clk-exynos5433 to common ARM64 functions. Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> ---quoted
if (IS_ERR(parent_clk)) { pr_err("%s: could not find bus clock %s; err = %ld\n",@@ -91,6 +112,46 @@ static int __init exynos_arm64_enable_bus_clk(struct device *dev, return 0; } +static int __init exynos_arm64_cmu_prepare_pm(struct device *dev, + const struct samsung_cmu_info *cmu)Align the arguments.
The same issue here as in my previous answer, unfortunately: when I try to align the `cmu' argument to match the open parentheses, it doesn't fit 80 characters limit, which doesn't look nice to me. Do you mind if I leave it as is?
Rest looks good to me. Best regards, Krzysztof
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel