Thread (91 messages) 91 messages, 3 authors, 2023-02-09

Re: [PATCH v1 33/45] clk: mediatek: Switch to module_platform_driver() where possible

From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Date: 2023-02-07 09:03:26
Also in: linux-clk, linux-mediatek, lkml

Il 07/02/23 07:37, Chen-Yu Tsai ha scritto:
On Mon, Feb 6, 2023 at 11:30 PM AngeloGioacchino Del Regno
[off-list ref] wrote:
quoted
Lots of clock drivers have got both .probe() and a .remove() callbacks:
switch from builtin_platform_driver() to module_platform_driver() so
that we actually register the .remove() callback.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
[...]
quoted
  drivers/clk/mediatek/clk-mt8195-vpp0.c         | 2 +-
  drivers/clk/mediatek/clk-mt8195-vpp1.c         | 2 +-
These two conflict with "clk: mediatek: remove MT8195 vppsys/0/1 simple_probe".
Since the rest of the vppsys stuff has been queued up, I'd like to see
that one get merged first so we don't have two drivers matching the same
compatible string.

This conflict also causes the last "clk: mediatek: Add MODULE_DEVICE_TABLE()
where appropriate" to not apply.

ChenYu
Yes that makes a lot of sense - this series is really big, so let's get the
8195 vppsys stuff merged in first.

I'll rebase on top of that for v2.

Angelo

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help