RE: [PATCH v2 -next] crypto: aspeed: fix type warnings

From
Neal Liu <neal_liu@aspeedtech.com>
Date
2023-02-03 03:25:37
Also in
linux-aspeed, linux-crypto, lkml
Reply to
Herbert Xu, 2023-02-03
quoted
quoted
diff --git a/drivers/crypto/aspeed/aspeed-acry.c
b/drivers/crypto/aspeed/aspeed-acry.c
index 164c524015f0..f2429e699d14 100644
--- a/drivers/crypto/aspeed/aspeed-acry.c
+++ b/drivers/crypto/aspeed/aspeed-acry.c
@@ -252,7 +252,7 @@ static int aspeed_acry_rsa_ctx_copy(struct
aspeed_acry_dev *acry_dev, void *buf,
quoted
quoted
  				    enum aspeed_rsa_key_mode mode)
  {
  	const u8 *src = xbuf;
-	u32 *dw_buf = (u32 *)buf;
+	__le32 *dw_buf = (__le32 *)buf;
All callers are passing acry_dev->buf_addr as buf, can just change
that type to __le32 * and deref here directly?
As buf is already void *, the cast can simply be removed.
I'll just remove the cast. Thanks for your suggestion.
quoted
quoted
  	int nbits, ndw;
  	int i, j, idx;
  	u32 data = 0;
@@ -302,7 +302,7 @@ static int aspeed_acry_rsa_ctx_copy(struct
aspeed_acry_dev *acry_dev, void *buf,
quoted
quoted
  static int aspeed_acry_rsa_transfer(struct aspeed_acry_dev *acry_dev)
  {
  	struct akcipher_request *req = acry_dev->req;
-	u8 *sram_buffer = (u8 *)acry_dev->acry_sram;
+	u8 __iomem *sram_buffer = (u8 __iomem *)acry_dev->acry_sram;
u8 cast seems unnecessary, readb takes (void *) and using "+ data_idx"
offset below anyway.
Either way a cast is unnecessary as (void __iomem *) converts to
(u8 __iomem *) just fine.
I'll just remove the cast too.

-Neal

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Thread (4 messages) 4 messages, 3 authors, last reply 2023-02-03
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help