Thread (5 messages) 5 messages, 2 authors, 2023-02-02

Re: cgroup user-after-free

From: "tj@kernel.org" <tj@kernel.org>
Date: 2023-02-02 19:50:15
Also in: cgroups, linux-mediatek, lkml

On Wed, Feb 01, 2023 at 06:04:04AM +0000, Lixiong Liu (刘利雄) wrote:
On Fri, 2023-01-13 at 13:40 +0800, lixiong liu wrote:
quoted
quoted
quoted
Root cause: 
cgroup_migrate_finish free cset’s cgroup,

but cgroup_sk_alloc use the freed cgroup,

then use-after-free happened.
Sounds similar to the problem fixed by 07fd5b6cdf3c ("cgroup: Use
separate
src/dst nodes when preloading css_sets for migration"). Can you try
it out?

Thanks.

Thanks for your quick feedback.


  
But we encountered use-after-free version

already contains this patch.



So, with this patch will also encounter

this use-after-free.

Thanks!
  Do you have any suggestion for this issue?
Unfortunately, there isn't a lot to latch onto. It's on an older kernel and
there's no reproducer. Refcnting in the path is tricky and it wouldn't be
too surprising for some bugs to be there. If you can repro on a recent
kernel, that'd help a lot.

Thanks.

-- 
tejun

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help