Re: [PATCH 3/8] serial: imx: do not sysrq broken chars
From: Johan Hovold <johan@kernel.org>
Date: 2023-01-16 15:24:50
Also in:
linux-serial
Possibly related (same subject, not in this thread)
- 2023-01-18 · Re: [PATCH 3/8] serial: imx: do not sysrq broken chars · Johan Hovold <johan@kernel.org>
- 2023-01-17 · Re: [PATCH 3/8] serial: imx: do not sysrq broken chars · Sergey Organov <hidden>
On Fri, Jan 13, 2023 at 09:43:29PM +0300, Sergey Organov wrote:
quoted hunk ↗ jump to hunk
Do not call uart_handle_sysrq_char() if we got any receive error along with the character, as we don't want random junk to be considered a sysrq. Signed-off-by: Sergey Organov <redacted> --- drivers/tty/serial/imx.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index e7fce31e460d..1c950112a598 100644 --- a/drivers/tty/serial/imx.c +++ b/drivers/tty/serial/imx.c@@ -911,9 +911,6 @@ static irqreturn_t __imx_uart_rxint(int irq, void *dev_id) continue; } - if (uart_handle_sysrq_char(&sport->port, (unsigned char)rx)) - continue; - if (unlikely(rx & URXD_ERR)) { if (rx & URXD_BRK) sport->port.icount.brk++;@@ -942,7 +939,8 @@ static irqreturn_t __imx_uart_rxint(int irq, void *dev_id) flg = TTY_OVERRUN; sport->port.sysrq = 0; - } + } else if (uart_handle_sysrq_char(&sport->port, (unsigned char)rx)) + continue;
Nit: missing braces {}
Note that you could also place just place this after the block due to
the reset of the sysrq time stamp.
if (sport->port.ignore_status_mask & URXD_DUMMY_READ) goto out;
Johan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel