RE: [PATCH V5 1/1] clk: imx8mp: Alias M7 SRC/DIV to M7 CORE
From: LI Qingwu <hidden>
Date: 2023-01-30 07:44:32
Also in:
linux-clk, lkml
-----Original Message----- From: Abel Vesa <redacted> Sent: Sunday, January 29, 2023 2:39 AM To: Stephen Boyd <sboyd@kernel.org>; LI Qingwu [off-list ref]; Peng Fan [off-list ref] Cc: LI Qingwu <redacted>; abelvesa@kernel.org; mturquette@baylibre.com; shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com; linux-imx@nxp.com; linux-clk@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; 18701859600@163.com; GEO-CHHER-bsp-development [off-list ref]; Marco Felsch [off-list ref] Subject: Re: [PATCH V5 1/1] clk: imx8mp: Alias M7 SRC/DIV to M7 CORE [Some people who received this message don't often get email from abel.vesa@linaro.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] This email is not from Hexagon's Office 365 instance. Please be careful while clicking links, opening attachments, or replying to this email. On 23-01-18 11:00:36, Stephen Boyd wrote:quoted
Quoting Abel Vesa (2023-01-16 06:28:33)quoted
On 23-01-11 11:10:30, LI Qingwu wrote:quoted
Defined IMX8MP_CLK_M7_SRC and IMX8MP_CLK_M7_DIV inimx8mp-clock.hquoted
quoted
quoted
but never assigned. It will cause the system to hang if using them. Alias IMX8MP_CLK_M7_SRC and IMX8MP_CLK_M7_DIV to IMX8MP_CLK_M7_CORE for backward compatibility. Fixes: 8c83a8ff4dd9 (clk: imx8mp: use imx8m_clk_hw_composite_core to simplify code) Reviewed-by: Marco Felsch <redacted> Reviewed-by: Abel Vesa <redacted> Signed-off-by: LI Qingwu <redacted>Stephen, can you please pick this up yourself?Is it needed for clk-fixes? When did the system start hanging?Li, Peng, can you provide some details here?
Since IMX8MP_CLK_M7_SRC and IMX8MP_CLK_M7_DIV were not assigned, if using any one of them in device tree, Linux system hanging after start M7 core. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel