Re: [PATCH 2/2] dt-bindings: mmc: correct pwrseq node names
From: Krzysztof Kozlowski <hidden>
Date: 2023-01-24 08:17:22
Also in:
linux-amlogic, linux-devicetree, linux-mmc, linux-rockchip, linux-samsung-soc, linux-sunxi, linux-tegra, lkml
On 20/01/2023 10:38, Heiko Stübner wrote:
Am Freitag, 20. Januar 2023, 09:57:22 CET schrieb Krzysztof Kozlowski:quoted
Node names should be generic and should not contain underscores. Signed-off-by: Krzysztof Kozlowski <redacted> --- Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml | 2 +- Documentation/devicetree/bindings/mmc/mmc-pwrseq-sd8787.yaml | 2 +- Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)diff --git a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml index 911a5996e099..588be73168fa 100644 --- a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml +++ b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml@@ -41,7 +41,7 @@ additionalProperties: false examples: - | #include <dt-bindings/gpio/gpio.h> - sdhci0_pwrseq { + pwrseq {[applicable for all 3 examples] hmm, power-sequences are not necessarily tied to an address and I guess it will be very much a common case to have multiple ones on a system. So might it be better to follow other patterns (like leds) to number them or suggest a "foo-pwrseq" / "pwrseq-foo"?
In such cases one can add number or descriptive suffix (pwrseq-0, pwrseq-foo), just like we do for regulators. However the examples have here only one node and in such case "pwrseq" is enough. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel