Hi,

On Fri, Jan 20, 2023 at 11:57 AM Matthias Brugger
[off-list ref] wrote:

On 01/01/2023 23:01, Bernhard Rosenkränzer wrote:

quoted

+             uart0: serial@11002000 {
+                     compatible = "mediatek,mt8365-uart", "mediatek,mt6577-uart";

Unfortunately we are missing this compatible in the binding description.

True, overlooked that one.

quoted

+             ssusb: usb@11201000 {
+                     compatible = "mediatek,mt8365-mtu3", "mediatek,mtu3";

Same here.

This is actually added by an earlier patch within this series (5/7),
but since it isn't used anywhere yet, might as well drop it for now,
"mediatek,mtu3" by itself works.

quoted

+                     usb_host: usb@11200000 {
+                             compatible = "mediatek,mt8365-xhci", "mediatek,mtk-xhci";

Same here.

Also added by an earlier patch within the series (6/7), and also not
used anywhere yet.

quoted

+     systimer: timer@10017000 {
+             compatible = "mediatek,mt6795-systimer";

Why don't we use a compatible like
"mediatek,mt8365-systimer", "mediatek,mt6795-systimer";

That was in an earlier revision and removed (because the binding
description wasn't merged yet). Can add it of course (but then
mediatek,mt8365-uart and friends should probably stay as well).

I'll post a new revision adding it back (along with the binding
description) and add the binding description for mt8365-uart as well
(getting it to the same place mediatek,mt8365-mtu3 and
mediatek,mt8365-xhci are now).
Let me know if you'd prefer a variant that drops mediatek,mt8365-uart,
mediatek,mt8365-mtu3, mediatek,mt8365-xhci and doesn't bring back
mediatek,mt8365-systimer -- either one works for me, the fallbacks are
sufficient to make it work.

ttyl
bero

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel