Thread (44 messages) 44 messages, 3 authors, 2023-02-09

Re: [PATCH v4 06/19] irqdomain: Drop revmap mutex

From: Thomas Gleixner <hidden>
Date: 2023-01-17 23:26:49
Also in: linux-mips, lkml, platform-driver-x86

On Mon, Jan 16 2023 at 14:50, Johan Hovold wrote:
The global irq_domain_mutex is now held in all paths that update the
revmap structures so there is no longer any need for the revmap mutex.
This can also go after the 3rd race fix, but ...
 static void irq_domain_clear_mapping(struct irq_domain *domain,
 				     irq_hw_number_t hwirq)
 {
+	lockdep_assert_held(&irq_domain_mutex);
these lockdep asserts want to be part of the [dis]association race
fixes. They are completely unrelated to the removal of the revmap_mutex.

Your race fixes change the locking and you want to ensure that all
callers comply right there, no?

Thanks,

        tglx

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help