Thread (8 messages) 8 messages, 2 authors, 2023-01-17

Re: [PATCH 4/4] i2c: i2c-mt65xx: add MT8365 SoC support

From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Date: 2023-01-17 12:51:23
Also in: linux-devicetree, linux-i2c, linux-mediatek, lkml

Il 17/01/23 09:49, Alexandre Mergnat ha scritto:
quoted hunk ↗ jump to hunk
From: Fabien Parent <redacted>

Add support for I2C on MT8365 SoCs.

Signed-off-by: Fabien Parent <redacted>
Signed-off-by: Alexandre Mergnat <redacted>
---
  drivers/i2c/busses/i2c-mt65xx.c | 14 ++++++++++++++
  1 file changed, 14 insertions(+)
diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
index d80e59340d97..2c9dbb42861a 100644
--- a/drivers/i2c/busses/i2c-mt65xx.c
+++ b/drivers/i2c/busses/i2c-mt65xx.c
@@ -511,6 +511,19 @@ static const struct mtk_i2c_compatible mt8192_compat = {
  	.max_dma_support = 36,
  };
  
+static const struct mtk_i2c_compatible mt8365_compat = {
This is exactly the same as mt8168_compat... so you can avoid adding this one
and you can also avoid adding the compatible to this driver.

This means that you can get it working with a devicetree declaring

compatible = "mediatek,mt8365-i2c", "mediatek,mt8168-i2c";

like you're already doing and without any addition to this driver at all.
So, you can drop this commit.

Regards,
Angelo



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help