Re: [PATCH 01/10] dt-bindings: media: mediatek,vcodec: Remove dma-ranges property

On Mon, 2023-01-16 at 09:06 +0100, Krzysztof Kozlowski wrote:

On 16/01/2023 09:01, Yong Wu (吴勇) wrote:

quoted

On Fri, 2023-01-13 at 09:25 +0100, Krzysztof Kozlowski wrote:

quoted

On 13/01/2023 07:01, Yong Wu wrote:

quoted

MediaTek iommu has already controlled the masters' iova ranges
by
the
master's larb/port id. then the dma-ranges property is
unnecessary
for

Sentences in English always start with a capital letter, however
also
they do not start with "Then". Make it a proper a proper
sentence.

Sorry for the syntax issues. I think it is "," before "then".

quoted

quoted

the master's node. the master is vcodec here.

Unnecessary or invalid? 

For mt8195, It is unnecessary. For the other SoC which doesn't use
parent/child node, the property is invalid, however, there is no
vcodec
node have this property in this case in the current upstream dts
nodes.

quoted

Don't you depend now on some feature of driver
added for example recently?

No. It doesn't depend on any the other patches. Just depend
on the code changing in this patchset. I just put the dt-binding
at the beginning of this series.

So this is an ABI change where you expect no upstream users to be
affected? Why you do not clarify it in commit msg?

Sorry I missed a venc node. In [9/10] of this series, I deleted this
property for mt8195 venc node, this has a little affect. 

VENC would like to locate the IOVA range of 4G-8G. Without this
patchset, It will fallback to 0-4GB. But this is not a fatal issue. It 
also work fine with 0-4GB iova. I will comment this in the commit
message in the next version.

quoted

quoted

quoted

Cc: Tiffany Lin <tiffany.lin@mediatek.com>
Cc: Andrew-CT Chen <andrew-ct.chen@mediatek.com>
Cc: Yunfei Dong <yunfei.dong@mediatek.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Krzysztof Kozlowski <redacted>

There is little point in storing output of get_maintainers.pl
forever
in
the git log. If you need it for some reason, please keep it after
-
--.

I did get the list from get_maintainers.pl. Sorry that I didn't
differentiate.

Getting the list from get_maintainers.pl is correct but storing it
forever in git log is really unnecessary. It's not useful. It's just
automated output, reproducible at any given time.

This patchset crosses several domains. This patch is about vcodec, the
next one is about jpeg and the later ones are about iommu.
The reviewers may be different, thus I use "Cc:" here. is this OK in
this case? or I should remove this, and put all of them in the cc list
of the mail.

Thanks.

quoted

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel