Re: [PATCH v5 01/10] spi: mtk-snfi: Change default page format to setup default setting
From: Matthias Brugger <matthias.bgg@gmail.com>
Date: 2022-12-19 15:30:46
Also in:
linux-devicetree, linux-mediatek, linux-spi, lkml
Thanks for your patch! There is something to improve please see below. On 19/12/2022 03:40, Xiangsheng Hou wrote:
quoted hunk ↗ jump to hunk
Change default page format to setup default setting since the sector size 1024 on MT7986 will lead to probe fail. Signed-off-by: Xiangsheng Hou <redacted> --- drivers/spi/spi-mtk-snfi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)diff --git a/drivers/spi/spi-mtk-snfi.c b/drivers/spi/spi-mtk-snfi.c index fa8412ba20e2..719fc6f53ab1 100644 --- a/drivers/spi/spi-mtk-snfi.c +++ b/drivers/spi/spi-mtk-snfi.c@@ -1430,8 +1430,7 @@ static int mtk_snand_probe(struct platform_device *pdev) // setup an initial page format for ops matching page_cache_op template // before ECC is called. - ret = mtk_snand_setup_pagefmt(ms, ms->caps->sector_size, - ms->caps->spare_sizes[0]); + ret = mtk_snand_setup_pagefmt(ms, SZ_2K, SZ_64);
Couldn't you just set sector_size in mt7986_snand_caps? Regards, Matthias
if (ret) {
dev_err(ms->dev, "failed to set initial page format\n");
goto disable_clk;_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel