Re: [PATCH V2 1/1] clk: imx8mp: Alias M7 SRC/DIV to M7 CORE
From: Marco Felsch <hidden>
Date: 2022-12-12 11:09:45
Also in:
linux-clk, lkml
Hi Li, On 22-12-12, LI Qingwu wrote:
quoted hunk ↗ jump to hunk
Defined IMX8MP_CLK_M7_SRC and IMX8MP_CLK_M7_DIV in imx8mp-clock.h but never assigned. It will cause the system to hang if using them. Alias IMX8MP_CLK_M7_SRC and IMX8MP_CLK_M7_DIV to IMX8MP_CLK_M7_CORE for backward compatibility. Fixes: 8c83a8ff4dd9 (clk: imx8mp: use imx8m_clk_hw_composite_core to simplify code) Signed-off-by: LI Qingwu <redacted> --- drivers/clk/imx/clk-imx8mp.c | 3 +++ 1 file changed, 3 insertions(+)diff --git a/drivers/clk/imx/clk-imx8mp.c b/drivers/clk/imx/clk-imx8mp.c index 652ae58c2735..bae5ecc81bdc 100644 --- a/drivers/clk/imx/clk-imx8mp.c +++ b/drivers/clk/imx/clk-imx8mp.c@@ -531,6 +531,9 @@ static int imx8mp_clocks_probe(struct platform_device *pdev) hws[IMX8MP_CLK_HSIO_AXI] = imx8m_clk_hw_composite("hsio_axi", imx8mp_hsio_axi_sels, ccm_base + 0x8380); hws[IMX8MP_CLK_MEDIA_ISP] = imx8m_clk_hw_composite("media_isp", imx8mp_media_isp_sels, ccm_base + 0x8400); + hws[IMX8MP_CLK_M7_SRC] = hws[IMX8MP_CLK_M7_CORE]; + hws[IMX8MP_CLK_M7_DIV] = hws[IMX8MP_CLK_M7_CORE];
Nit: Can you please move them below the assignment of the IMX8MP_CLK_M7_CORE, so the M7 clocks are bundled at one place. Regards, Marco
+
/* CORE SEL */
hws[IMX8MP_CLK_A53_CORE] = imx_clk_hw_mux2("arm_a53_core", ccm_base + 0x9880, 24, 1, imx8mp_a53_core_sels, ARRAY_SIZE(imx8mp_a53_core_sels));
--
2.25.1
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel