Re: [PATCH mm-unstable v1 17/20] drm/exynos: remove FOLL_FORCE usage
From: Daniel Vetter <hidden>
Date: 2022-11-16 11:05:13
Also in:
dri-devel, linux-alpha, linux-fsdevel, linux-kselftest, linux-media, linux-mips, linux-mm, linux-perf-users, linux-rdma, linux-samsung-soc, linux-security-module, linux-um, linuxppc-dev, lkml, sparclinux
On Wed, Nov 16, 2022 at 11:26:56AM +0100, David Hildenbrand wrote:
FOLL_FORCE is really only for ptrace access. As we unpin the pinned pages using unpin_user_pages_dirty_lock(true), the assumption is that all these pages are writable. FOLL_FORCE in this case seems to be a legacy leftover. Let's just remove it. Cc: Inki Dae <inki.dae@samsung.com> Cc: Seung-Woo Kim <sw0312.kim@samsung.com> Cc: Kyungmin Park <kyungmin.park@samsung.com> Cc: David Airlie <airlied@gmail.com> Cc: Daniel Vetter <redacted> Cc: Krzysztof Kozlowski <redacted> Signed-off-by: David Hildenbrand <redacted>
Reviewed-by: Daniel Vetter <redacted> Plus ack for merging through the appropriate non-drm tree. -Daniel
quoted hunk ↗ jump to hunk
--- drivers/gpu/drm/exynos/exynos_drm_g2d.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c index 471fd6c8135f..e19c2ceb3759 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c@@ -477,7 +477,7 @@ static dma_addr_t *g2d_userptr_get_dma_addr(struct g2d_data *g2d, } ret = pin_user_pages_fast(start, npages, - FOLL_FORCE | FOLL_WRITE | FOLL_LONGTERM, + FOLL_WRITE | FOLL_LONGTERM, g2d_userptr->pages); if (ret != npages) { DRM_DEV_ERROR(g2d->dev,-- 2.38.1
-- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel