Re: [PATCH 1/2] dt-bindings: net: rockchip-dwmac: add rk3568 xpcs compatible
From: Krzysztof Kozlowski <hidden>
Date: 2022-11-29 08:49:55
Also in:
linux-devicetree, lkml, netdev
On 29/11/2022 08:27, Chukun Pan wrote:
quoted hunk ↗ jump to hunk
The gmac of RK3568 supports RGMII/SGMII/QSGMII interface. This patch adds a compatible string for the required clock. Signed-off-by: Chukun Pan <redacted> --- Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 6 ++++++ 1 file changed, 6 insertions(+)diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml index 42fb72b6909d..36b1e82212e7 100644 --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml@@ -68,6 +68,7 @@ properties: - mac_clk_rx - aclk_mac - pclk_mac + - pclk_xpcs - clk_mac_ref - clk_mac_refout - clk_mac_speed@@ -90,6 +91,11 @@ properties: The phandle of the syscon node for the peripheral general register file. $ref: /schemas/types.yaml#/definitions/phandle + rockchip,xpcs: + description: + The phandle of the syscon node for the peripheral general register file.
You used the same description as above, so no, you cannot have two properties which are the same. syscons for GRF are called "rockchip,grf", aren't they? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel