Re: [PATCH -next v2] clk: Fix one kernel-doc comment
From: Randy Dunlap <hidden>
Date: 2022-11-22 04:26:10
Also in:
linux-clk, linux-sunxi, lkml
Hi-- On 11/21/22 18:38, Yang Li wrote:
drivers/clk/sunxi-ng/ccu_mmc_timing.c:54: warning: expecting prototype for sunxi_ccu_set_mmc_timing_mode(). Prototype was for sunxi_ccu_get_mmc_timing_mode() instead Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3230 Reported-by: Abaci Robot <redacted> Signed-off-by: Yang Li <redacted>
This looks good, although this file needs more work in a few places. Acked-by: Randy Dunlap <redacted> Thanks.
quoted hunk ↗ jump to hunk
--- change in v2: --According to Randy's suggestion, use the '-' replace ':' to separate function name and description. drivers/clk/sunxi-ng/ccu_mmc_timing.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/clk/sunxi-ng/ccu_mmc_timing.c b/drivers/clk/sunxi-ng/ccu_mmc_timing.c index de33414fc5c2..88c456a8e49b 100644 --- a/drivers/clk/sunxi-ng/ccu_mmc_timing.c +++ b/drivers/clk/sunxi-ng/ccu_mmc_timing.c@@ -43,7 +43,7 @@ int sunxi_ccu_set_mmc_timing_mode(struct clk *clk, bool new_mode) EXPORT_SYMBOL_GPL(sunxi_ccu_set_mmc_timing_mode); /** - * sunxi_ccu_set_mmc_timing_mode: Get the current MMC clock timing mode + * sunxi_ccu_get_mmc_timing_mode - Get the current MMC clock timing mode * @clk: clock to query * * Returns 0 if the clock is in old timing mode, > 0 if it is in
-- ~Randy _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel