On 17/11/22 10:08, Peter Zijlstra wrote:

On Wed, Nov 02, 2022 at 06:33:32PM +0000, Valentin Schneider wrote:

quoted

This simply wraps around the arch function and prepends it with a
tracepoint, similar to send_call_function_single_ipi().

Signed-off-by: Valentin Schneider <vschneid@redhat.com>
---
 kernel/smp.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/kernel/smp.c b/kernel/smp.c
index e2ca1e2f31274..c4d561cf50d45 100644
--- a/kernel/smp.c
+++ b/kernel/smp.c

@@ -160,6 +160,13 @@ void __init call_function_init(void)
     smpcfd_prepare_cpu(smp_processor_id());
 }

+static inline void

Given the use of _RET_IP_, I would strongly recommend you use
__always_inline.

Noted, thanks

quoted

+send_call_function_ipi_mask(const struct cpumask *mask)
+{
+	trace_ipi_send_cpumask(mask, _RET_IP_, func);

What's func?

A rebase fail... That's only plugged in later.

quoted

+	arch_send_call_function_ipi_mask(mask);
+}

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel