Re: [PATCH 04/44] KVM: Teardown VFIO ops earlier in kvm_exit()
From: Eric Farman <farman@linux.ibm.com>
Date: 2022-11-07 18:02:34
Also in:
kvm, kvm-riscv, kvmarm, linux-mips, linux-riscv, linux-s390, linuxppc-dev, lkml
On Wed, 2022-11-02 at 23:18 +0000, Sean Christopherson wrote:
Move the call to kvm_vfio_ops_exit() further up kvm_exit() to try and
bring some amount of symmetry to the setup order in kvm_init(), and
more
importantly so that the arch hooks are invoked dead last by
kvm_exit().
This will allow arch code to move away from the arch hooks without
any
change in ordering between arch code and common code in kvm_exit().
That kvm_vfio_ops_exit() is called last appears to be 100%
arbitrary. It
was bolted on after the fact by commit 571ee1b68598 ("kvm: vfio: fix
unregister kvm_device_ops of vfio"). The nullified
kvm_device_ops_table
is also local to kvm_main.c and is used only when there are active
VMs,
so unless arch code is doing something truly bizarre, nullifying the
table earlier in kvm_exit() is little more than a nop.
Signed-off-by: Sean Christopherson <seanjc@google.com>
---
virt/kvm/kvm_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)Reviewed-by: Eric Farman <farman@linux.ibm.com> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel