Re: [PATCH v1 3/6] dt-bindings: hwmon: Add hpe,gxp-fan-ctrl
From: Krzysztof Kozlowski <hidden>
Date: 2022-11-06 10:38:36
Also in:
linux-devicetree, linux-doc, linux-hwmon, lkml
On 04/11/2022 20:36, nick.hawkins@hpe.com wrote:
From: Nick Hawkins <nick.hawkins@hpe.com> This provides the base registers address, programmable logic registers address, and the function 2 registers to allow control access of the HPE fans on the GXP SoC.
What is "This"? If "This patch", then drop it. https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 If "This hardware" then please instead describe the hardware, not it components. What are its features? If it controls the fan, then why there are no PWM-related cells? How do you set the speed?
quoted hunk ↗ jump to hunk
Signed-off-by: Nick Hawkins <nick.hawkins@hpe.com> --- .../bindings/hwmon/hpe,gxp-fan-ctrl.yaml | 41 +++++++++++++++++++ 1 file changed, 41 insertions(+) create mode 100644 Documentation/devicetree/bindings/hwmon/hpe,gxp-fan-ctrl.yamldiff --git a/Documentation/devicetree/bindings/hwmon/hpe,gxp-fan-ctrl.yaml b/Documentation/devicetree/bindings/hwmon/hpe,gxp-fan-ctrl.yaml new file mode 100644 index 000000000000..40a5d9cd0a30 --- /dev/null +++ b/Documentation/devicetree/bindings/hwmon/hpe,gxp-fan-ctrl.yaml@@ -0,0 +1,41 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/hwmon/hpe,gxp-fan-ctrl.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: GXP Fan Controller + +maintainers: + - Nick Hawkins <nick.hawkins@hpe.com> + +properties: + compatible: + const: hpe,gxp-fan-ctrl + + reg: + items: + - description: Fan controller base register + - description: Programmable logic registers base + - description: Function 2 registers base
Drop "register" and "base" from all descriptions
+ + reg-names: + items: + - const: base + - const: plreg
Drop reg suffix
+ - const: fn2reg
Drop reg suffix
+
+required:
+ - compatible
+ - reg
+ - reg-names
+
+additionalProperties: false
+
+examples:
+ - |
+ fanctrl@1000c00 {fan-controller
+ compatible = "hpe,gxp-fan-ctrl"; + reg = <0x1000c00 0x200>, <0xd1000000 0xff>, <0x80200000 0x100000>; + reg-names = "base", "plreg", "fn2reg"; + };
Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel