-----Original Message-----
From: Krzysztof Kozlowski <redacted>
Sent: 2022年10月21日 0:32
To: Joy Zou <redacted>; vkoul@kernel.org; robh+dt@kernel.org;
krzysztof.kozlowski+dt@linaro.org; shawnguo@kernel.org;
s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com
Cc: S.J. Wang <redacted>; martink@posteo.de;
dev@lynxeye.de; alexander.stein@ew.tq-group.com; Peng Fan
[off-list ref]; david@ixit.cz; aford173@gmail.com; Hongxing Zhu
[off-list ref]; dl-linux-imx [off-list ref];
dmaengine@vger.kernel.org; devicetree@vger.kernel.org;
linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org
Subject: [EXT] Re: [PATCH v7 1/2] dt-bindings: fsl-imx-sdma: Convert imx sdma
to DT schema

Caution: EXT Email

On 20/10/2022 06:14, Joy Zou wrote:

quoted

Convert the i.MX SDMA binding to DT schema format using json-schema.

quoted

---
 .../devicetree/bindings/dma/fsl,imx-sdma.yaml | 147
++++++++++++++++++  .../devicetree/bindings/dma/fsl-imx-sdma.txt  |
118 --------------
 2 files changed, 147 insertions(+), 118 deletions(-)  create mode
100644 Documentation/devicetree/bindings/dma/fsl,imx-sdma.yaml
 delete mode 100644
Documentation/devicetree/bindings/dma/fsl-imx-sdma.txt

diff --git a/Documentation/devicetree/bindings/dma/fsl,imx-sdma.yaml

b/Documentation/devicetree/bindings/dma/fsl,imx-sdma.yaml
new file mode 100644
index 000000000000..3da65d3ea4af

--- /dev/null
+++ b/Documentation/devicetree/bindings/dma/fsl,imx-sdma.yaml

@@ -0,0 +1,147 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2
+---
+$id:
+https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi

+cetree.org%2Fschemas%2Fdma%2Ffsl%2Cimx-sdma.yaml%23&data=05
%7C01%

quoted

+7Cjoy.zou%40nxp.com%7C405bb49028e340afdc9408dab2b89251%7C686ea
1d3bc2b

quoted

+4c6fa92cd99c5c301635%7C0%7C0%7C638018803042580036%7CUnknown
%7CTWFpbGZ

quoted

+sb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6M
n0%

quoted

+3D%7C3000%7C%7C%7C&sdata=tgNngxTlIBOhIXt0VYJACNM%2FV%2F0
LWCXyTYVr

quoted

+rZ5PfoY%3D&reserved=0
+$schema:
+https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi

+cetree.org%2Fmeta-schemas%2Fcore.yaml%23&data=05%7C01%7Cjoy.z
ou%4

quoted

+0nxp.com%7C405bb49028e340afdc9408dab2b89251%7C686ea1d3bc2b4c6
fa92cd99

quoted

+c5c301635%7C0%7C0%7C638018803042580036%7CUnknown%7CTWFpbG
Zsb3d8eyJWIj

quoted

+oiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3
000%7

quoted

+C%7C%7C&sdata=MNltJ7MuOpabpjY%2FTdi8IDagtgiFz1vgUCUhs68ChV
U%3D&am

quoted

+p;reserved=0
+
+title: Freescale Smart Direct Memory Access (SDMA) Controller for
+i.MX
+
+maintainers:
+  - Joy Zou [off-list ref]
+

You need to reference dma-controller.yaml schema.

Thank you very much for your comments.
I will add the dma-controller quotes.
BR
Joy Zou

quoted

+properties:
+  compatible:
+    oneOf:

(...)

quoted

+
+  gpr:
+    $ref: /schemas/types.yaml#/definitions/phandle
+    description: The phandle to the General Purpose Register (GPR)
+ node
+
+  fsl,sdma-event-remap:
+    $ref: /schemas/types.yaml#/definitions/uint32-matrix
+    maxItems: 2
+    items:
+      items:
+        - description: GPR register offset
+        - description: GPR register shift
+        - description: GPR register value
+    description: |
+      Register bits of sdma event remap, the format is <reg shift val>.
+      The order is <RX>, <TX>.
+
+  clocks:
+    maxItems: 2
+
+  clock-names:
+    items:
+      - const: ipg
+      - const: ahb
+
+  iram:
+    $ref: /schemas/types.yaml#/definitions/phandle
+    description: The phandle to the On-chip RAM (OCRAM) node.
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - fsl,sdma-ram-script-name
+  - "#dma-cells"

and then this can one be dropped.

Thanks your comments.
I have tried to delete the additionalProperties, but I run dtbs_check. The log as follow:
'oneOf' conditional failed, one must be fixed:
	'unevaluatedProperties' is a required property
	'additionalProperties' is a required property
So I think the property may not be dropped.
BR
Joy Zou

quoted

+
+additionalProperties: false

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel