RE: [Patch v3 01/15] dt-bindings: media: s5p-mfc: Add new DT schema for MFC

-----Original Message-----
From: Krzysztof Kozlowski [mailto:krzk@kernel.org]
Sent: 12 October 2022 18:27
To: aakarsh jain <redacted>; linux-arm-
kernel@lists.infradead.org; linux-media@vger.kernel.org; linux-
kernel@vger.kernel.org; devicetree@vger.kernel.org
Cc: m.szyprowski@samsung.com; andrzej.hajda@intel.com;
mchehab@kernel.org; hverkuil-cisco@xs4all.nl;
ezequiel@vanguardiasur.com.ar; jernej.skrabec@gmail.com;
benjamin.gaignard@collabora.com; stanimir.varbanov@linaro.org;
dillon.minfei@gmail.com; david.plowman@raspberrypi.com;
mark.rutland@arm.com; robh+dt@kernel.org; krzk+dt@kernel.org;
andi@etezian.org; alim.akhtar@samsung.com; aswani.reddy@samsung.com;
pankaj.dubey@samsung.com; linux-fsd@tesla.com; smitha.t@samsung.com
Subject: Re: [Patch v3 01/15] dt-bindings: media: s5p-mfc: Add new DT
schema for MFC

On 11/10/2022 08:25, aakarsh jain wrote:

quoted

From: Smitha T Murthy <redacted>

Convert DT schema for s5p-mfc in yaml format

Convert S5P-MFC bindings to DT schema.

You also missed full-stop.

Ok will address it in next series.

My second comment was ignored here.

I missed one review comment which was related to change in commit message. Will address it in next series.

quoted

Cc: linux-fsd@tesla.com
Signed-off-by: Smitha T Murthy <redacted>
Signed-off-by: Aakarsh Jain <redacted>
---
 .../devicetree/bindings/media/s5p-mfc.txt     |  75 --------
 .../bindings/media/samsung,s5p-mfc.yaml       | 163

++++++++++++++++++

quoted

 2 files changed, 163 insertions(+), 75 deletions(-)  create mode
100644 Documentation/devicetree/bindings/media/samsung,s5p-mfc.yaml

diff --git a/Documentation/devicetree/bindings/media/s5p-mfc.txt

b/Documentation/devicetree/bindings/media/s5p-mfc.txt
index aa54c8159d9f..8b137891791f 100644

--- a/Documentation/devicetree/bindings/media/s5p-mfc.txt
+++ b/Documentation/devicetree/bindings/media/s5p-mfc.txt

This is a friendly reminder during the review process.

It seems my previous comments were not fully addressed. Maybe my
feedback got lost between the quotes, maybe you just forgot to apply it.
Please go back to the previous discussion and either implement all requested
changes or keep discussing them.

Thank you.

Apart from your second review comment  I guess we have addressed all your review comments in the current patch.
Please review other changes as well and let us know if any changes required.

Thanks for the review.

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel