Thread (2 messages) read the whole thread 2 messages, 2 authors, 2022-10-12

Re: [PATCH -next] media: sun6i-csi: Remove unnecessary print function dev_err()

From: Jernej Škrabec <jernej.skrabec@gmail.com>
Date: 2022-10-12 22:07:48
Also in: linux-media, linux-sunxi, lkml

Hi Yang,

Dne četrtek, 29. september 2022 ob 07:40:03 CEST je Yang Li napisal(a):
The print function dev_err() is redundant because platform_get_irq()
already prints an error.

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2314
Reported-by: Abaci Robot <redacted>
Signed-off-by: Yang Li <redacted>
Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Best regards,
Jernej
quoted hunk ↗ jump to hunk
---
 drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c
b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c index
8b99c17e8403..9119f5e0e05e 100644
--- a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c
+++ b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c
@@ -913,7 +913,6 @@ static int sun6i_csi_resources_setup(struct
sun6i_csi_device *csi_dev,

 	irq = platform_get_irq(platform_dev, 0);
 	if (irq < 0) {
-		dev_err(dev, "failed to get interrupt\n");
 		ret = -ENXIO;
 		goto error_clock_rate_exclusive;
 	}
--
2.20.1.7.g153144c


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help