Re: [PATCH v2 3/7] dts: arm64: mt8195: add MMSYS and MUTEX configuration for VPPSYS
From: Krzysztof Kozlowski <hidden>
Date: 2022-10-11 12:23:55
Also in:
linux-devicetree, linux-mediatek, lkml
On 11/10/2022 03:03, Moudy Ho wrote:
From: "Roy-CW.Yeh" <redacted> Compatible names, node names, and GCE client registers for VPPSYS0 and VPPSYS1 should be renamed or added to match the binding file requirements. Also, add two nodes for MT8195 VPPSYS MUTEX. Signed-off-by: Roy-CW.Yeh <redacted> Signed-off-by: Moudy Ho <redacted>
Use subject prefixes matching the subsystem (git log --oneline -- ...).
quoted hunk ↗ jump to hunk
--- arch/arm64/boot/dts/mediatek/mt8195.dtsi | 30 ++++++++++++++++++++---- 1 file changed, 26 insertions(+), 4 deletions(-)diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi index 905d1a90b406..3e73bd58e54d 100644 --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi@@ -1476,12 +1476,23 @@ #clock-cells = <1>; }; - vppsys0: clock-controller@14000000 { - compatible = "mediatek,mt8195-vppsys0"; + vppsys0: syscon@14000000 { + compatible = "mediatek,mt8195-vppsys0", + "mediatek,mt8195-mmsys", "syscon";
No. You change multiple pieces in one patch, some of them have much bigger impact, like adding compatibles. Split and describe *why* you are changing it.
reg = <0 0x14000000 0 0x1000>;
+ mediatek,gce-client-reg = <&gce1 SUBSYS_1400XXXX 0 0x1000>;
#clock-cells = <1>;
};
+ mutex@1400f000 {
+ compatible = "mediatek,mt8195-vpp-mutex";And you add some new nodes in a cleanup patch... Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel