On Tue, 2022-10-04 at 11:36 +0200, AngeloGioacchino Del Regno wrote:

Il 30/09/22 16:56, Trevor Wu ha scritto:

quoted

Add mt8188 platform driver.

Signed-off-by: Trevor Wu <redacted>
---
This patch depends on the following series that has not been
accepted.

[1] Add power domain support for MT8188

https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-mediatek/list/?series=681359__;!!CTRNKA9wMg0ARbw!3U0sxKMgA8D7xhhaJ3nSEOj4DWLrWj6_QsYGwDbCvtBvZpoKuDq5yXLDfMW1acoPog$

quoted

 
(linux/soc/mediatek/infracfg.h is included)
---
  sound/soc/mediatek/Kconfig                 |   13 +
  sound/soc/mediatek/Makefile                |    1 +
  sound/soc/mediatek/mt8188/Makefile         |   12 +
  sound/soc/mediatek/mt8188/mt8188-afe-pcm.c | 2945
++++++++++++++++++++

..snip

quoted

+#include <linux/arm-smccc.h>
+#include <linux/delay.h>
+#include <linux/dma-mapping.h>
+#include <linux/module.h>
+#include <linux/mfd/syscon.h>
+#include <linux/of.h>
+#include <linux/of_address.h>
+#include <linux/of_platform.h>
+#include <linux/pm_runtime.h>
+#include <linux/reset.h>
+#include <linux/soc/mediatek/infracfg.h>
+#include <linux/soc/mediatek/mtk_sip_svc.h>
+#include <sound/pcm_params.h>
+#include "mt8188-afe-common.h"
+#include "mt8188-afe-clk.h"
+#include "mt8188-reg.h"
+#include "../common/mtk-afe-platform-driver.h"
+#include "../common/mtk-afe-fe-dai.h"
+
+#define MTK_SIP_AUDIO_CONTROL MTK_SIP_SMC_CMD(0x517)

This definition goes to include/linux/soc/mediatek/mtk_sip_svc.h

Hi Angelo,

If I move the definition to "include/linux/soc/mediatek/mtk_sip_svc.h",
I should submit it to another tree.
In the case, do you have any suggestion to handle the dependent
problem?

quoted

+
+#define MT8188_MEMIF_BUFFER_BYTES_ALIGN  (0x40)
+#define MT8188_MEMIF_DL7_MAX_PERIOD_SIZE (0x3fff)
+
+#define MEMIF_AXI_MINLEN 9 //register default value

...and please fix comments style.

OK.

quoted

+
+struct mtk_dai_memif_priv {
+	unsigned int asys_timing_sel;
+	unsigned int fs_timing;
+};
+

..snip..

quoted

+
+MODULE_DESCRIPTION("Mediatek ALSA SoC AFE platform driver for
8188");

MediaTek SoC AFE platform driver for ALSA MT8188

OK. I will update the description in V2.

Thanks,
Trevor

quoted

+MODULE_AUTHOR("Chun-Chia.Chiu [off-list ref]");
+MODULE_LICENSE("GPL");

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel