Hi Krzysztof,

Sorry for the late reply.
Thanks for your review.

On Sun, 2022-09-18 at 10:38 +0100, Krzysztof Kozlowski wrote:

On 14/09/2022 13:45, Johnson Wang wrote:

quoted

Add the new binding documentation for MediaTek frequency hopping
and spread spectrum clocking control.

Co-developed-by: Edward-JW Yang <redacted>
Signed-off-by: Edward-JW Yang <redacted>
Signed-off-by: Johnson Wang <redacted>
---
 .../bindings/arm/mediatek/mediatek,fhctl.yaml | 47
+++++++++++++++++++
 1 file changed, 47 insertions(+)
 create mode 100644
Documentation/devicetree/bindings/arm/mediatek/mediatek,fhctl.yaml

diff --git
a/Documentation/devicetree/bindings/arm/mediatek/mediatek,fhctl.yam
l
b/Documentation/devicetree/bindings/arm/mediatek/mediatek,fhctl.yam
l
new file mode 100644
index 000000000000..7b0fd0889bb6

--- /dev/null
+++

b/Documentation/devicetree/bindings/arm/mediatek/mediatek,fhctl.yam
l

Name of file matching compatible.

I will change file name in the next version.

quoted

@@ -0,0 +1,47 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: 

https://urldefense.com/v3/__http://devicetree.org/schemas/arm/mediatek/mediatek,fhctl.yaml*__;Iw!!CTRNKA9wMg0ARbw!3e-QEzJcF8ER6bi9pBinXakWUMDsurZPy-q69INHqalP_evj50meSBC7SN0ukZhfEmO-$
 
+$schema: 
https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!3e-QEzJcF8ER6bi9pBinXakWUMDsurZPy-q69INHqalP_evj50meSBC7SN0ukZLSg9mh$
 
+
+title: MediaTek frequency hopping and spread spectrum clocking
control
+
+maintainers:
+  - Edward-JW Yang [off-list ref]
+
+description: |
+  Frequency hopping control (FHCTL) is a piece of hardware that
control
+  some PLLs to adopt "hopping" mechanism to adjust their
frequency.
+  Spread spectrum clocking (SSC) is another function provided by
this hardware.
+
+properties:
+  compatible:
+    const: mediatek,mt8186-fhctl
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    description: Phandles of the PLL with FHCTL hardware
capability.

You need constraints here.

I will improve this in the next version.

quoted

+
+  mediatek,hopping-ssc-percents:

That's not the correct unit suffix name.

https://urldefense.com/v3/__https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/property-units.yaml__;!!CTRNKA9wMg0ARbw!3e-QEzJcF8ER6bi9pBinXakWUMDsurZPy-q69INHqalP_evj50meSBC7SN0ukaKEhFnN$

I will go with "mediatek,hopping-ssc-percent" in the next version.

Thanks!

BRs,
Johnson Wang

quoted

+    description: The percentage of spread spectrum clocking for
one PLL.
+    $ref: /schemas/types.yaml#/definitions/uint32

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel