On Fri, 2022-09-23 at 14:34 -0700, Han Jingoo wrote:

On Wed, Sep 21, 2022 Andy Shevchenko [off-list ref] wrote:

quoted

On Wed, Sep 21, 2022 at 4:48 AM ChiaEn Wu [off-list ref] wrote:

quoted

On Sun, Sep 18, 2022 at 3:22 AM Han Jingoo [off-list ref] wrote:

quoted

On Mon, Aug 29, 2022 ChiaEn Wu [off-list ref] wrote:

quoted

quoted

quoted

+#define MT6370_ITORCH_MIN_uA           25000
+#define MT6370_ITORCH_STEP_uA          12500
+#define MT6370_ITORCH_MAX_uA           400000
+#define MT6370_ITORCH_DOUBLE_MAX_uA    800000
+#define MT6370_ISTRB_MIN_uA            50000
+#define MT6370_ISTRB_STEP_uA           12500
+#define MT6370_ISTRB_MAX_uA            1500000
+#define MT6370_ISTRB_DOUBLE_MAX_uA     3000000

Use upper letters as below:

For microseconds (and other -seconds) the common practice (I assume
historically) is to use upper letters, indeed. But for current it's
more natural to use small letters for unit multiplier as it's easier
to read and understand.

I think it's fine. see:

commit 22735ce857a2d9f4e6eec37c36be3fcf9d21d154
Author: Joe Perches [off-list ref]
Date:   Wed Jul 3 15:05:33 2013 -0700

    checkpatch: ignore SI unit CamelCase variants like "_uV"
    
    Many existing variable names use SI like variants that should be otherwise
    obvious and acceptable.


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel