Re: [PATCH 2/2] gpio: rockchip: request GPIO mux to pinctrl when setting direction
From: Heiko Stuebner <heiko@sntech.de>
Date: 2022-09-23 18:41:31
Also in:
linux-gpio, linux-rockchip, lkml, stable
Am Freitag, 23. September 2022, 16:51:41 CEST schrieb Quentin Schulz:
From: Quentin Schulz <redacted>
Before the split of gpio and pinctrl sections in their own driver,
rockchip_set_mux was called in pinmux_ops.gpio_set_direction for
configuring a pin in its GPIO function.
This is essential for cases where pinctrl is "bypassed" by gpio
consumers otherwise the GPIO function is not configured for the pin and
it does not work. Such was the case for the sysfs/libgpiod userspace
GPIO handling.
Let's call pinctrl_gpio_direction_input/output when setting the
direction of a GPIO so that the pinctrl core requests from the rockchip
pinctrl driver to put the pin in its GPIO function.
Fixes: 9ce9a02039de ("pinctrl/rockchip: drop the gpio related codes")
Fixes: 936ee2675eee ("gpio/rockchip: add driver for rockchip gpio")
Cc: stable@vger.kernel.org
Signed-off-by: Quentin Schulz <redacted>cool, thanks a lot for reimplementing this Reviewed-by: Heiko Stuebner <heiko@sntech.de> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel