Re: [PATCH v4 05/10] tty: serial: extract tx_ready() from __serial_lpc32xx_tx()

On Tue, 20 Sep 2022, Jiri Slaby wrote:

The condition in __serial_lpc32xx_tx()'s loop is barely readable.
Extract it to a separate function. This will make the cleanup in the
next patches easier too.

Cc: Vladimir Zapolskiy <vz@mleia.com>
Cc: <redacted>
Signed-off-by: Jiri Slaby <redacted>

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

I noticed that wait_for_xmit_ready() uses < 32 for the similar check 
which seems fishy...


-- 
 i.