Thread (25 messages) 25 messages, 4 authors, 2022-09-14

Re: [PATCH V2 3/7] arm64/perf: Update struct pmu_hw_events for BRBE

From: Mark Brown <broonie@kernel.org>
Date: 2022-09-14 09:37:42
Also in: linux-perf-users, lkml

On Wed, Sep 14, 2022 at 09:09:10AM +0530, Anshuman Khandual wrote:
Something like the following change moves the buffer allocation off the stack,
although it requires updating the driver, and buffer assignment during a PMU
interrupt. But it does seem to work (will require some more testing).
Yeah, looks like it should do the trick.
+
+               events->branch_records = kmalloc(sizeof(struct brbe_records), flags);
+               WARN_ON(!events->branch_records);
No need for the WARN_ON(), if we run out of memory the memory
management code is already very loud about it.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help