Re: Re: [PATCH v5 8/8] loongarch: efi: enable generic EFI compressed boot
From: Ard Biesheuvel <ardb@kernel.org>
Date: 2022-09-12 10:18:26
Also in:
linux-efi, lkml
On Sun, 11 Sept 2022 at 16:03, 陈华才 [off-list ref] wrote:
quoted hunk ↗ jump to hunk
quoted
-----原始邮件----- 发件人: "Ard Biesheuvel" [off-list ref] 发送时间:2022-09-10 22:28:04 (星期六) 收件人: "陈华才" [off-list ref] 抄送: linux-efi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "James E.J. Bottomley" [off-list ref], "Matthew Garrett" [off-list ref], "Peter Jones" [off-list ref], "Ilias Apalodimas" [off-list ref], "Heinrich Schuchardt" [off-list ref], "AKASHI Takahiro" [off-list ref], "Palmer Dabbelt" [off-list ref], "Atish Patra" [off-list ref], "Arnd Bergmann" [off-list ref], "Xi Ruoyao" [off-list ref], "Lennart Poettering" [off-list ref], "Jeremy Linton" [off-list ref], "Will Deacon" [off-list ref], "Catalin Marinas" [off-list ref] 主题: Re: [PATCH v5 8/8] loongarch: efi: enable generic EFI compressed boot On Sat, 10 Sept 2022 at 15:22, 陈华才 [off-list ref] wrote:quoted
Hi, Ard, I prefer to give a chance to disable ZBOOT, so I don't want to select EFI_ZBOOT unconditionally in Kconfig, and then the Makefile can be like this:diff --git a/arch/loongarch/Makefile b/arch/loongarch/Makefile index c3f579bdf9e5..bc6fe65125f5 100644 --- a/arch/loongarch/Makefile +++ b/arch/loongarch/Makefile@@ -14,6 +14,10 @@ else KBUILD_IMAGE := $(boot)/vmlinux.efi endif +ifdef CONFIG_EFI_ZBOOT +KBUILD_IMAGE := $(boot)/vmlinuz.efi +endif + archscripts: scripts_basic $(Q)$(MAKE) $(build)=arch/loongarch/boot/tools relocsOK, I will fold this in. This actually aligns it with the other architectures, so I prefer this approach as well.Thank you, and if "make install" can also handle the zboot case, that's even better. :)diff --git a/arch/loongarch/Makefile b/arch/loongarch/Makefile index c3f579bdf9e5..5480fe2de7cd 100644 --- a/arch/loongarch/Makefile +++ b/arch/loongarch/Makefile@@ -137,7 +137,11 @@ vmlinux.elf vmlinux.efi vmlinuz.efi: vmlinux core-y += arch/loongarch/boot/dts/ install: +ifndef CONFIG_EFI_ZBOOT $(Q)install -D -m 755 $(KBUILD_IMAGE) $(INSTALL_PATH)/vmlinux-$(KERNELRELEASE) +else + $(Q)install -D -m 755 $(KBUILD_IMAGE) $(INSTALL_PATH)/vmlinuz-$(KERNELRELEASE) +endif $(Q)install -D -m 644 .config $(INSTALL_PATH)/config-$(KERNELRELEASE) $(Q)install -D -m 644 System.map $(INSTALL_PATH)/System.map-$(KERNELRELEASE)
Is there any reason in particular this is open coded like this? Other
architectures just do something like
install:
$(call cmd,install)
and be done with it.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel