Re: [PATCH v2] mfd: stmpe: switch to using gpiod API
From: Lee Jones <lee@kernel.org>
Date: 2022-09-08 10:40:03
Also in:
linux-devicetree, linux-tegra, lkml
From: Lee Jones <lee@kernel.org>
Date: 2022-09-08 10:40:03
Also in:
linux-devicetree, linux-tegra, lkml
On Tue, 06 Sep 2022, Dmitry Torokhov wrote:
This patch switches the driver away from legacy gpio/of_gpio API to gpiod API, and removes use of of_get_named_gpio_flags() which I want to make private to gpiolib. We also need to patch relevant DTS files, as the original code relied on the fact that of_get_named_gpio_flags() would fetch any data encoded in GPIO flags, even if it does not reflect valid flags for a GPIO. Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> --- v1->v2: - add DTS changes, as noticed by Francesco Dolcini. I guess we could do a dance of changing stmpe to check the flags coming from DTS and try to distinguish IRQ flags from proper GPIO flags, then have a separate patch changing DTSes, and finally a 2nd patch to stmpe to use GPIOD API, but I am hoping we could apply this in one go... arch/arm/boot/dts/tegra30-apalis-v1.1.dtsi | 2 +- arch/arm/boot/dts/tegra30-apalis.dtsi | 2 +- arch/arm/boot/dts/tegra30-colibri.dtsi | 2 +- drivers/mfd/stmpe.c | 36 ++++++++-------------- 4 files changed, 16 insertions(+), 26 deletions(-)
Applied, thanks. -- Lee Jones [李琼斯] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel