RE: [PATCH v4 2/2] edac: zynqmp_ocm: Add EDAC support for ZynqMP OCM

Hi Boris,

-----Original Message-----
From: Borislav Petkov <bp@alien8.de>
Sent: Wednesday, September 7, 2022 7:31 PM
To: Potthuri, Sai Krishna <sai.krishna.potthuri@amd.com>
Cc: Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski
[off-list ref]; Michal Simek
[off-list ref]; Mauro Carvalho Chehab
[off-list ref]; Tony Luck [off-list ref]; James Morse
[off-list ref]; Robert Richter [off-list ref];
devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
kernel@vger.kernel.org; linux-edac@vger.kernel.org;
saikrishna12468@gmail.com; git (AMD-Xilinx) [off-list ref]; Datta,
Shubhrajyoti [off-list ref]
Subject: Re: [PATCH v4 2/2] edac: zynqmp_ocm: Add EDAC support for
ZynqMP OCM

On Wed, Sep 07, 2022 at 04:45:31PM +0530, Sai Krishna Potthuri wrote:

quoted

Add EDAC support for Xilinx ZynqMP OCM Controller, this driver reports
CE and UE errors based on the interrupts, and also creates ue/ce sysfs
entries for error injection.

Signed-off-by: Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>
Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>

I think you folks need to brush up on

Documentation/process/submitting-patches.rst

in order to build your SOB chain properly.

Got it, i will add "Co-developed-by" tag and send v5.

quoted

diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig index

58ab63642e72..08adedfd42b5 100644

--- a/drivers/edac/Kconfig
+++ b/drivers/edac/Kconfig

@@ -539,4 +539,13 @@ config EDAC_DMC520
 	  Support for error detection and correction on the
 	  SoCs with ARM DMC-520 DRAM controller.

+config EDAC_ZYNQMP_OCM
+	tristate "Xilinx ZynqMP OCM Controller"
+	depends on ARCH_ZYNQMP || COMPILE_TEST

We already have an EDAC driver which depends on ARCH_ZYNQMP - the
Synopsys one. Can this one be made part of it?

Synopsys EDAC driver is targeted for DDR Memory Controller and this driver
is for OCM (On Chip Memory) Controller, both are different hardware controllers.

Regards
Sai Krishna
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel