Re: [PATCH v1 1/1] iio: adc: mxs-lradc-adc: Get rid of OF specifics
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2022-09-06 13:45:23
Also in:
linux-iio, lkml
On Mon, Jun 20, 2022 at 08:42:25PM +0100, Jonathan Cameron wrote:
On Fri, 3 Jun 2022 18:10:06 +0100 Jonathan Cameron [off-list ref] wrote:quoted
On Mon, 30 May 2022 20:33:24 +0300 Andy Shevchenko [off-list ref] wrote:quoted
First of all, the additional conversion from vIRQ, and this is exactly what is returned by platform_get_irq_byname(), to vIRQ is not needed.Confusing sentence form. Perhaps: First, the additional conversion from vIRQ (returned by platform_get_irq_byname()) to vIRQ is not needed.quoted
Hence, drop no-op call to irq_of_parse_and_map(). Second, assign the firmware node instead of of_node.
...
quoted
Seems sensible to me, but I'd like a sanity check from someone more familiar with this driver.This one has been outstanding for a few weeks. I'd still like an Ack or similar form someone who knows this device well. If no one has looked at it in a week or so I'll just go with my judgement and pick it up.
Any news on this one? Maybe I need to resend with the better commit message? -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel