Thread (12 messages) 12 messages, 2 authors, 2022-09-06

Re: [PATCH V8 4/6] soc: imx: add i.MX93 media blk ctrl driver

From: Shawn Guo <shawnguo@kernel.org>
Date: 2022-09-06 02:09:32
Also in: linux-devicetree, lkml

On Mon, Sep 05, 2022 at 02:47:16PM +0800, Peng Fan wrote:
[...]
quoted
quoted
+struct imx93_blk_ctrl_data {
+	const struct imx93_blk_ctrl_domain_data *domains;
+	const struct imx93_blk_ctrl_domain_data *bus;
It looks confusing to claim 'bus' as an imx93_blk_ctrl_domain_data.  I
would suggest you have 'related' fields directly defined in
imx93_blk_ctrl_data.
This would implies a bit large change to this driver.

Should I use a new V1 for the patchset or continue V9 for next version?
I think v9 is fine.

Shawn

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help