Re: [PATCH linux-next] ARM: omap1: remove redundant variables err
From: Janusz Krzysztofik <jmkrzyszt@gmail.com>
Date: 2022-09-05 20:46:19
Also in:
linux-omap, lkml
On Tuesday, 30 August 2022 16:21:36 CEST cgel.zte@gmail.com wrote:
From: Jinpeng Cui <redacted> Rturn value directly from platform_device_register() instead of getting value from redundant variable err. Reported-by: Zeal Robot <redacted> Signed-off-by: Jinpeng Cui <redacted>
Acked-by: Janusz Krzysztofik <jmkrzyszt@gmail.com> Note: The same change, form a different author @zte.com.cn, with a different wording in commit message and description, was submitted a few hours before this one. However, I decided to respond with my Ack to this one because the other one was not sent to linux-omap@vger.kernel.org, then it didn't reach OMAP patchwork. If my decision is not in line with some recommendations and I should rather prefer the submission sent earlier then please let me know and I'll respond with my Ack to it as well. Thanks, Janusz
quoted hunk ↗ jump to hunk
--- arch/arm/mach-omap1/board-ams-delta.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)diff --git a/arch/arm/mach-omap1/board-ams-delta.c b/arch/arm/mach-omap1/board-ams-delta.c index 651c28d81132..e5531ef0fbde 100644 --- a/arch/arm/mach-omap1/board-ams-delta.c +++ b/arch/arm/mach-omap1/board-ams-delta.c@@ -822,8 +822,6 @@ static int __init modem_nreset_init(void) */ static int __init ams_delta_modem_init(void) { - int err; - if (!machine_is_ams_delta()) return -ENODEV;@@ -832,9 +830,7 @@ static int __init ams_delta_modem_init(void) /* Initialize the modem_nreset regulator consumer before use */ modem_priv.regulator = ERR_PTR(-ENODEV); - err = platform_device_register(&ams_delta_modem_device); - - return err; + return platform_device_register(&ams_delta_modem_device); } arch_initcall_sync(ams_delta_modem_init);
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel