Re: [PATCH V7 6/8] perf/tools: Extend branch type classification
From: Anshuman Khandual <hidden>
Date: 2022-09-05 08:00:40
Also in:
linux-perf-users, lkml
On 9/2/22 23:16, Arnaldo Carvalho de Melo wrote:
Em Fri, Sep 02, 2022 at 02:31:34PM -0300, Arnaldo Carvalho de Melo escreveu:quoted
Em Thu, Sep 01, 2022 at 10:37:24AM +0530, Anshuman Khandual escreveu:quoted
On 8/31/22 02:41, Arnaldo Carvalho de Melo wrote:quoted
Strange: 75 8.89 ubuntu:20.04-x-powerpc64el : FAIL gcc version 10.3.0 (Ubuntu 10.3.0-1ubuntu1~20.04) inlined from 'branch_type_stat_display' at util/branch.c:152:4: /usr/powerpc64le-linux-gnu/include/bits/stdio2.h:100:10: error: '%8s' directive argument is null [-Werror=format-overflow=] 100 | return __fprintf_chk (__stream, __USE_FORTIFY_LEVEL - 1, __fmt, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 101 | __va_arg_pack ()); | ~~~~~~~~~~~~~~~~~Indeed. But this new code block here looks exact same like the previous and existing one i.e with branch_new_name() and PERF_BR_NEW_MAX. The complain is that - '%8s' directive argument is NULL. This warning might just be a false positive [1], because of a compiler problem on powerpc64el ? But please do let me know if something needs to be changed here to avoid this warning. [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90036So, I tried not returning NULL in the functions that are ultimately called, but that didn't help, so I'll try just disabling that specific warning for this specific file.Got it building:
Thanks Arnaldo, I guess all the tool changes in this series, along with this build will land in linux-next later for more test coverage.
quoted hunk ↗ jump to hunk
23.68 ubuntu:20.04-x-powerpc64el : Ok powerpc64le-linux-gnu-gcc (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0 BUILD_TARBALL_HEAD=b0f700972d9d0c9b8e73f69ccf0e56d74c580d71 With:quoted
From b0f700972d9d0c9b8e73f69ccf0e56d74c580d71 Mon Sep 17 00:00:00 2001From: Arnaldo Carvalho de Melo <redacted> Date: Fri, 2 Sep 2022 14:35:26 -0300 Subject: [PATCH 1/1] perf build: Avoid false positive with -Werror=format-overflow= with gcc 10.3.0 on powerpc When building with gcc 10.3.0 on powerpc this is happening: 75 8.89 ubuntu:20.04-x-powerpc64el : FAIL gcc version 10.3.0 (Ubuntu 10.3.0-1ubuntu1~20.04) inlined from 'branch_type_stat_display' at util/branch.c:152:4: /usr/powerpc64le-linux-gnu/include/bits/stdio2.h:100:10: error: '%8s' directive argument is null [-Werror=format-overflow=] 100 | return __fprintf_chk (__stream, __USE_FORTIFY_LEVEL - 1, __fmt, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 101 | __va_arg_pack ()); | ~~~~~~~~~~~~~~~~~ Looks related to: [10/11/12/13 Regression] false positive: directive argument is null [-Werror=format-overflow=] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90036 So lets disable this just for the util/branch.o file. Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Anshuman Khandual <redacted> Cc: Catalin Marinas <catalin.marinas@arm.com> Cc: Ingo Molnar <mingo@redhat.com> Cc: James Clark <redacted> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Robin Murphy <robin.murphy@arm.com> Cc: Suzuki Poulouse <suzuki.poulose@arm.com> Cc: Thomas Gleixner <redacted> Cc: Will Deacon <will@kernel.org> Link: http://lore.kernel.org/lkml/YxI99uLvpgAZjm2r@kernel.org (local) Signed-off-by: Arnaldo Carvalho de Melo <redacted> --- tools/perf/util/Build | 4 ++++ 1 file changed, 4 insertions(+)diff --git a/tools/perf/util/Build b/tools/perf/util/Build index 8fd6dc8de5210336..20a5524e88a04d44 100644 --- a/tools/perf/util/Build +++ b/tools/perf/util/Build@@ -223,6 +223,10 @@ CFLAGS_llvm-utils.o += -DPERF_INCLUDE_DIR="BUILD_STR($(perf_include_dir_SQ))" # avoid compiler warnings in 32-bit mode CFLAGS_genelf_debug.o += -Wno-packed +# avoid false positive when building with gcc 10.3.0 on powerpc +# See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90036 +CFLAGS_branch.o += -Wno-format-overflow + $(OUTPUT)util/parse-events-flex.c $(OUTPUT)util/parse-events-flex.h: util/parse-events.l $(OUTPUT)util/parse-events-bison.c $(call rule_mkdir) $(Q)$(call echo-cmd,flex)$(FLEX) -o $(OUTPUT)util/parse-events-flex.c \
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel