Re: [PATCH 0/4] ARM: footbridge: cleanups
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
Date: 2022-09-04 12:12:39
Also in:
lkml
On Sun, Sep 04, 2022 at 12:43:48PM +0100, Marc Zyngier wrote:
On Thu, 18 Aug 2022 22:15:46 +0100, Arnd Bergmann [off-list ref] wrote:quoted
From: Arnd Bergmann <arnd@arndb.de> I had an older patch to remove the addin mode for footbridge, which nobody is using any more, and I found a few other small cleanups that are worth doing here. Footbridge is now the only platform with a custom __virt_to_bus() for ISA DMA, and a custom phys_to_dma() for PCI devices. Both just add a fixed offset, so there is probably a better way of doing the same without a custom helper function. Arnd Arnd Bergmann (4): ARM: footbridge: remove addin mode ARM: footbridge: remove leftover from personal-server ARM: footbridge: move isa-dma support into footbridge ARM: footbridge: limit CONFIG_ISA to CATS arch/arm/Kconfig | 5 -- arch/arm/include/asm/hardware/dec21285.h | 13 ---- arch/arm/kernel/Makefile | 1 - arch/arm/mach-footbridge/Kconfig | 30 +------- arch/arm/mach-footbridge/Makefile | 5 +- arch/arm/mach-footbridge/common.c | 73 ++----------------- arch/arm/mach-footbridge/dc21285.c | 61 +++++----------- .../arm/{kernel => mach-footbridge}/dma-isa.c | 7 +- arch/arm/mach-footbridge/dma.c | 58 --------------- .../mach-footbridge/include/mach/isa-dma.h | 14 +--- .../arm/mach-footbridge/include/mach/memory.h | 22 ------ arch/arm/mach-footbridge/isa.c | 14 ++-- drivers/tty/serial/21285.c | 3 - 13 files changed, 42 insertions(+), 264 deletions(-) rename arch/arm/{kernel => mach-footbridge}/dma-isa.c (98%) delete mode 100644 arch/arm/mach-footbridge/dma.c -- 2.29.2 Cc: Russell King <linux@armlinux.org.uk> Cc: Christoph Hellwig <hch@lst.de> Cc: Linus Walleij <redacted> Cc: Marc Zyngier <maz@kernel.org>I finally managed to give this a go on my netwinder using v2 of patch 5/4 (!), and the box booted nicely. Note that apart from the serial console, everything I'm using on this box is PCI (I tried to enable sound and failed, probably because I can't select CONFIG_ISA anymore on this machine).
That tends to mean, therefore, that the statement "CONFIG_ISA is for add-in cards" is wrong, because it's caused a user-visible regression by killing sound support on Netwinders! -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel